Add reusable ownable module and refactor network fungible faucet to use it #2228

afa7789 · 2026-01-05T21:23:59Z

This PR creates a new reusable ownable module that centralizes ownership management functionality for account components.

The network fungible faucet has been refactored to use this module instead of implementing ownership logic inline, replacing the local is_owner procedure with ownable::check_owner and updating the storage slot to use the standard ownable::owner_config slot name. The network_fungible_faucet component now also exports transfer_ownership from the ownable module.

This change improves code reusability and maintainability by standardizing ownership logic across components. New tests have been added to verify ownership checks work correctly, and all existing tests continue to pass.

OpenZeppelin/miden-confidential-contracts#34 ( regarding this discussion ).

onurinanc

Thank you @afa7789 for this work! I have few comments from my side. I believe @mmagician would provide a more detailed feedback related to ownable logic.
Also, for the folder structure such as how we would like to have the utils under the standards.

Additionally, from the discussion here: OpenZeppelin/miden-confidential-contracts#34 (comment)

Is it possible to design an address, which is not usable for anyone such as address(0)?

crates/miden-standards/asm/standards/utils/ownable.masm

crates/miden-testing/tests/scripts/faucet.rs

onurinanc · 2026-01-06T10:41:46Z

crates/miden-standards/asm/account_components/network_fungible_faucet.masm

 #
 # See the `NetworkFungibleFaucet` Rust type's documentation for more details.

+use miden::standards::utils::ownable


This is nice!
We might want to have type of utils such as access utils or token utils. Also, we can provide some documents under the utils. So, I think we can go one step further and have
standards::utils::access::ownable

crates/miden-standards/asm/standards/faucets/network_fungible.masm

afa7789 · 2026-01-06T15:13:39Z

@mmagician can you also take a look! ? :)

afa7789 · 2026-01-06T17:32:00Z

We may need to refactor.
AS the ownership transfer doesn't work, I believe it could be related to the storage slot.

We may need to specify the storage slot at the specific 'master' .masm and not the component.

"const OWNER_CONFIG_SLOT=word("miden::standards::utils::access::ownable::owner_config")"

At network fungible instead of ownable.masm?

cargo test -p miden-testing test_transfer_ownership_flow -- --nocapture

afa7789 · 2026-01-06T21:39:35Z

We may need to refactor. The ownership transfer doesn't work, I believe it could be related to the storage slot.

I did a full refactor in branch openzeppelin/ownable_dos - moved all ownership logic inline to network_fungible.masm (no external module calls). Same result: set_item fails with "storage slot not found".

Root cause: When a note script calls an account procedure via call, the kernel's authenticate_account_origin sees the note script hash as the caller, not an account procedure. This blocks all storage writes from note scripts, regardless of where the code is defined.

What works: Owner verification for minting (read-only).

What doesn't work: transfer_ownership (requires write).

This appears to be a fundamental Miden limitation.

@mmagician is there a way to workaround it ?

bobbinth · 2026-01-08T08:07:44Z

crates/miden-standards/asm/account_components/network_fungible_faucet.masm

 #
 # See the `NetworkFungibleFaucet` Rust type's documentation for more details.

+use miden::standards::utils::access::ownable


nit: since we are using the fully-qualified path for exports, we shouldn't need to add this import.

An alternative could be to do something like this:

use miden::standards::utils::access::ownable pub use ownable::transfer_ownership

But we kind of been using fully-qualified paths in such situations - so, probably should stick with it.

crates/miden-standards/asm/standards/utils/access/ownable.masm

crates/miden-standards/asm/standards/faucets/network_fungible.masm

crates/miden-standards/asm/standards/access/ownable.masm

crates/miden-standards/asm/standards/utils/access/ownable.masm

crates/miden-standards/asm/standards/access/ownable.masm

onurinanc · 2026-01-08T13:19:08Z

crates/miden-standards/asm/standards/access/ownable.masm

+    # => [pad(16)]
+
+    # ---- Write zero AccountId to storage ----
+    push.0.0.0.0


I wonder if we can model zero address not to be usable anyone, and we can name it AddressZero in the kernel. @mmagician

Yes, we can assume that nobody will be able to come up with address that is all zeros (if they can, then collision-resistance of the hash function is broken, and we have bigger problems).

We could also add this in the kernel - but not sure where yet (and maybe that should be a separate issue).

For now, I would create a constant in this file and then just do something like push.ZERO_ADDRESS.

We could also add this in the kernel - but not sure where yet

I don't think there would be any benefits to doing this in the kernel. In Ethereum this is not defined at the protocol level, but rather it's assumed (by preimage resistance) that no one will have the key to that account.

bobbinth

Looks good! Thank you! I some comments inline - mostly minor.

crates/miden-standards/asm/standards/access/ownable.masm

crates/miden-standards/asm/standards/utils/access/ownable.masm

bobbinth · 2026-01-09T00:38:42Z

crates/miden-standards/asm/standards/access/ownable.masm

+    # => [pad(16)]
+
+    # ---- Write zero AccountId to storage ----
+    push.0.0.0.0


Yes, we can assume that nobody will be able to come up with address that is all zeros (if they can, then collision-resistance of the hash function is broken, and we have bigger problems).

We could also add this in the kernel - but not sure where yet (and maybe that should be a separate issue).

For now, I would create a constant in this file and then just do something like push.ZERO_ADDRESS.

crates/miden-standards/asm/standards/faucets/network_fungible.masm

afa7789 · 2026-01-10T12:07:20Z

@bobbinth @onurinanc @mmagician I changed/solved the issues/suggestions highlighted here in the PR.

crates/miden-standards/asm/standards/access/ownable.masm

bobbinth

Looks good! Thank you. I left some more comments inline. Could you also please a changelog entry for this PR?

crates/miden-standards/asm/standards/faucets/network_fungible.masm

crates/miden-standards/asm/standards/access/ownable.masm

afa7789 · 2026-01-14T14:57:57Z

@bobbinth done !

bobbinth · 2026-01-15T04:43:30Z

@afa7789 thank you! Seems like there are some outstanding merge conflicts. Could you resolve them?

afa7789 · 2026-01-15T12:15:02Z

@afa7789 thank you! Seems like there are some outstanding merge conflicts. Could you resolve them?

done.
had to merge from miden origin and solved locally.

@bobbinth

bobbinth

Looks good! Thank you! I primarily focused on non-test code.

Maybe @onurinanc wants to take another look?

…den#2178)

* chore: rename auth to auth_scheme * chore: split up asm/account_components * chore: only use recursive masm finder * chore: rename to remove "_recursive" * chore: align build.rs files * chore: adjust comment

* Update memory.rs * Update memory.masm * Update crates/miden-lib/src/transaction/memory.rs Co-authored-by: Philipp Gackstatter <PhilippGackstatter@users.noreply.github.com> * Update crates/miden-lib/src/transaction/memory.rs Co-authored-by: Philipp Gackstatter <PhilippGackstatter@users.noreply.github.com> * Update memory.rs * Update test_fpi.rs * Update memory.masm * Update kernel_procedures.rs * fix: make format * Update memory.masm * Update account.masm * Update memory.rs * Update account.masm --------- Co-authored-by: Philipp Gackstatter <PhilippGackstatter@users.noreply.github.com>

* feat: move standard note scripts into standard library Move note script logic from standalone files in `note_scripts/` directory to `miden::standards::notes` namespace modules. This enables dynamic access to script roots via `procref` instead of hardcoding values. Changes: - Add new modules under `standards/notes/`: p2id, p2ide, swap, burn, mint - Each module contains a `pub proc main` with the script logic - Original note script files now serve as minimal wrappers calling `exec.<note>::main` Closes 0xMiden#2243 * chore: add changelog entry for note scripts refactoring * docs: fix namespace references in note script documentation * chore: update docs contracts->standards --------- Co-authored-by: Marti <marti@miden.team>

Previously, the Minimum Supported Rust Version (MSRV) check ran on every pull request and push to next. This was expensive because cargo-msrv downloads additional Rust toolchains to verify compatibility. Now the MSRV check only runs: - On push to main/next (in release-plz-dry-run.yml) - When publishing a release (in release-plz.yml) This makes PR CI faster and uses less memory. Any MSRV issues will still be caught before publication, and can be fixed locally using the scripts/check-msrv.sh script. Changes: - Delete .github/workflows/msrv.yml - Add MSRV check steps to release-plz-dry-run.yml - Add MSRV check steps to release-plz.yml

…ts (0xMiden#2246)

* feat: Define `NoteTag` to wrap arbitrary `u32` * feat: Rework note tag docs and constructors * chore: Remove use case constructors and refactor swap tag * feat: Remove note tag validation * feat: Rename account ID conversion to account target * feat: Update note tag docs * chore: add changelog * chore: Make `NoteMetadata::new` infallible * chore: address review comments on docs * chore: remove outdated note tag rules in metadata docs * chore: remove `create_mock_notes` (0xMiden#2236) * chore: Rename `create_random_note` to `*_default_*` and add pub helper * chore: replace create_mock_notes in test_epilogue * chore: Remove `create_mock_notes` --------- Co-authored-by: Bobbin Threadbare <43513081+bobbinth@users.noreply.github.com>

* feat: Implement `NoteAttachment` * chore: Precompute `NoteHeader` in `PartialNote` * feat: Remove aux, exec hint from `NoteMetadata`; add attachment * feat: refactor output note memory layout and metadata building * chore: adapt tx event extraction to new output_note::create stack state * chore: prepare `compute_output_notes_commitment` for attachment hashing * chore: Update input notes commitment to include attachment * chore: include attachment in output notes commitment * chore: return attachment and header from `input_note_get_metadata` * chore: return attachment and header from `output_note_get_metadata` * fix: compilation errors in `miden-testing` * chore: regenerate kernel procedure hashes * chore: add changelog * chore: rename attachment_types to attachment_type_info for clarity * chore: Move content to word encoding to method * chore: rename `Raw` -> `Word` and `Commitment` -> `Array` * chore: Rename `NoteAttachmentCommitment` to `*Array`

* feat: Implement `output_note_set_attachment` kernel API * feat: Implement `miden::protocol` set_attachment wrappers * feat: Emit event during `set_attachment` for tx host * chore: add tests for `set_attachment` APIs * chore: regenerate kernel procedure hashes * chore: add changelog * chore: rename `Raw` -> `Word` and `Commitment` -> `Array` * fix: renamed attachment content variants * chore: make attachment content type constants public * chore: move note ptr to idx conversion to helper * chore: merge attachment validation procedures into one * chore: simplify setting output note attachment type info * chore: make `set_attachment` public * fix: commitment to array rename * chore: require attachment_type == 0 when content type is None * chore: enforce none / attachment type restriction in `NoteAttachment`

) * feat: Implement `NetworkAccountTarget` * chore: Let SPAWN note create output notes with attachment * chore: test creating note with NetworkAccountTarget attachment * chore: add changelog * fix: don't use super::* import * feat: Add `WellKnownNoteAttachment` * chore: Use 8-bit tag for exec hint; remove `AfterBlockNumber` * chore: improve network account target error

…::create` (0xMiden#2260) * chore: remove aux and exec hint from protocol::output_note::create * fix: tests in `test_epilogue.rs` * fix: update calls to `output_note::create` in note tests * fix: update calls to `output_note::create` in tx and account_delta test * fix: remove aux and exec hint from `send_note_body` * chore: remove exec hint and aux from swap note * chore: update MINT note to new output_note::create signature * fix: remove aux/exec hint from faucet tests * fix: replace aux with attachment in p2id constructors * fix: replace aux with attachment in mint, burn, p2ide notes * chore: remove aux and exec hint metadata methods * chore: remove aux/exec hint from `NoteBuilder` * chore: add changelog * feat: Take attachment param in `faucets::distribute` * chore: update MINT note to new faucets::distribute params * feat: allow attachment for payback note in SWAP note * fix: calls to `distribute` in tests; remove mention of aux * Revert "feat: Take attachment param in `faucets::distribute`" This reverts commit 8c27281. * chore: return note_idx from `distribute` * Partially revert chore: update MINT note to new faucets::distribute params * chore: update MINT note with new note inputs memory offets * chore: set attachment in MINT note * Partially revert fix: calls to `distribute` in tests; remove mention of aux * feat: Add attachment to note in `send_body` * chore: remove unnecessary `push.0`

…xMiden#2268) * feat: Pad elements in `NoteAttachmentArray` before committing * chore: Rename `NoteAttachmentType` -> `NoteAttachmentScheme` * chore: rename "attachment type info" to "attachment kind scheme" * chore: Rename `NoteAttachmentContentType` -> `NoteAttachmentKind` * chore: rename attachment scheme untyped to unknown * chore: Swap kind and scheme in procedure signatures * chore: add changelog * Revert "feat: Pad elements in `NoteAttachmentArray` before committing" This reverts commit cfe9702. * chore: rename `NoteAttachmentScheme::unknown` to `none` * fix: more content type -> attachment kind renames

…and integrate into network fungible faucet

…th default attachments in faucet tests

afa7789 · 2026-01-16T00:17:43Z

I had to force push to sign all the commits, started without signing.

mmagician

LGTM with minor adjustments

crates/miden-standards/asm/standards/access/ownable.masm

crates/miden-testing/tests/scripts/faucet.rs

Co-authored-by: Marti <marcin.gorny.94@protonmail.com>

…OWNER constant

mmagician

Thanks for the quick adjustments!

onurinanc reviewed Jan 6, 2026

View reviewed changes

afa7789 marked this pull request as ready for review January 6, 2026 15:13

afa7789 marked this pull request as draft January 6, 2026 21:37

bobbinth reviewed Jan 8, 2026

View reviewed changes

crates/miden-standards/asm/standards/utils/access/ownable.masm Outdated Show resolved Hide resolved

afa7789 force-pushed the openzeppelin/ownable branch from 42c387a to 176eb62 Compare January 8, 2026 10:41

afa7789 marked this pull request as ready for review January 8, 2026 10:46

onurinanc reviewed Jan 8, 2026

View reviewed changes

onurinanc mentioned this pull request Jan 8, 2026

Extending Network Fungible Faucets with Optional Pausable Logic #2241

Open

onurinanc reviewed Jan 8, 2026

View reviewed changes

bobbinth reviewed Jan 9, 2026

View reviewed changes

onurinanc reviewed Jan 13, 2026

View reviewed changes

bobbinth reviewed Jan 14, 2026

View reviewed changes

afa7789 requested review from bobbinth, mmagician and onurinanc January 14, 2026 15:06

afa7789 force-pushed the openzeppelin/ownable branch from bfd268a to 067df65 Compare January 15, 2026 12:06

bobbinth approved these changes Jan 15, 2026

View reviewed changes

bobbinth and others added 5 commits January 15, 2026 20:45

chore: fix TransactionAuthenticator::get_signature() docs

9a73293

chore: fix lints

534aa0e

test: simplify codebuilder creation (0xMiden#2175)

b351216

feat: Add From<&ExecutedTransaction> for TransactionHeader impl (0xMi…

26f67f1

…den#2178)

chore: update protocol library docs (0xMiden#2179)

8d70adc

Farukest and others added 17 commits January 15, 2026 20:48

feat: add AccountId::parse() for hex and bech32 formats (0xMiden#2223)

1512add

chore: organize miden-standards (0xMiden#2227)

7421546

* chore: rename auth to auth_scheme * chore: split up asm/account_components * chore: only use recursive masm finder * chore: rename to remove "_recursive" * chore: align build.rs files * chore: adjust comment

chore: add error messages to asserts (0xMiden#2239)

34392ae

feat: Read foreign account inputs and witnesses from transaction inpu…

49377cd

…ts (0xMiden#2246)

feat: insert unpadded note inputs into advice_inputs (0xMiden#2232)

b680282

feat: add ownable standard module for component ownership management …

83dc36d

…and integrate into network fungible faucet

refactor: simplify note creation by replacing auxiliary parameters wi…

fdfbfb5

…th default attachments in faucet tests

chore(cargo): fixing lint issues.

1d1bdf3

afa7789 force-pushed the openzeppelin/ownable branch from c905269 to 1d1bdf3 Compare January 15, 2026 23:48

Merge branch 'next' into openzeppelin/ownable

c8bcbfe

afa7789 force-pushed the openzeppelin/ownable branch from decbd4d to c8bcbfe Compare January 16, 2026 00:10

Merge branch 'next' into openzeppelin/ownable

1229dc0

mmagician approved these changes Jan 16, 2026

View reviewed changes

afa7789 and others added 4 commits January 16, 2026 09:38

Update crates/miden-standards/asm/standards/access/ownable.masm

d122730

Co-authored-by: Marti <marcin.gorny.94@protonmail.com>

Update crates/miden-standards/asm/standards/access/ownable.masm

ac2374c

Co-authored-by: Marti <marcin.gorny.94@protonmail.com>

Update crates/miden-standards/asm/standards/access/ownable.masm

196a491

Co-authored-by: Marti <marcin.gorny.94@protonmail.com>

chore: Refactor error handling in faucet tests to use ERR_SENDER_NOT_…

b3ae5f8

…OWNER constant

mmagician approved these changes Jan 16, 2026

View reviewed changes

chore: lint fix

5428d53

bobbinth merged commit aacee91 into 0xMiden:next Jan 16, 2026
15 checks passed

Add reusable ownable module and refactor network fungible faucet to use it #2228

Add reusable ownable module and refactor network fungible faucet to use it #2228

Uh oh!

Conversation

afa7789 commented Jan 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

onurinanc left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

onurinanc Jan 6, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

afa7789 commented Jan 6, 2026

Uh oh!

afa7789 commented Jan 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

afa7789 commented Jan 6, 2026

Uh oh!

bobbinth Jan 8, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

onurinanc Jan 8, 2026

Choose a reason for hiding this comment

Uh oh!

bobbinth Jan 9, 2026

Choose a reason for hiding this comment

Uh oh!

mmagician Jan 9, 2026

Choose a reason for hiding this comment

Uh oh!

bobbinth left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bobbinth Jan 9, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

afa7789 commented Jan 10, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bobbinth left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

afa7789 commented Jan 5, 2026 •

edited

Loading

afa7789 commented Jan 6, 2026 •

edited

Loading

afa7789 commented Jan 15, 2026 •

edited

Loading